Upgrade managedservices.registrationdefinitions API version from 2019-06-01 to 2022-10-01
#19499
Conversation
…-06-01 to 2022-10-01
There was a problem hiding this comment.
@neil-yechenwei Thanks for the update. I've run the tests locally and the import check for azurerm_lighthouse_assignment doesn't seem to be working. I'm not sure if this is a regression but could you take a look at this? Other than that, this should be good to merge.
|
@manicminer , if you rollback to main branch, this TC still failed with same error. So I think this TC has failed for a long time not regression issue. As you can see, I didn't update the API version for LighthouseAssignment. I only updated the API version for LighthouseDefinition. Hence, I think this failed TC isn't related with this PR. |
|
@manicminer , after investigated, I found the root cause is that the logic of checking the existing resource is removed from this Lighthouse Assignment resource by this PR. So the test case failed. But per my understanding, it shouldn't be removed. So I updated this PR to add it back. Now all TCs passed. --- PASS: TestAccLighthouseAssignment_basic (182.81s) |
There was a problem hiding this comment.
Great, thanks for spotting that and fixing @neil-yechenwei. Tests look good.
|
This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR is to upgrade
managedservices.registrationdefinitionsAPI version from2019-06-01to2022-10-01.Note: As the TCs related with Lighthouse Definition are skipped in Teamcity due to test data issue, so I ran them on my local and they passed.
--- PASS: TestAccLighthouseDefinition_basic (131.62s)
--- PASS: TestAccLighthouseDefinition_requiresImport (175.23s)
--- PASS: TestAccLighthouseDefinition_complete (161.23s)
--- PASS: TestAccLighthouseDefinition_update (559.91s)
--- PASS: TestAccLighthouseDefinition_emptyID (136.87s)
--- PASS: TestAccLighthouseDefinition_plan (127.90s)